Is the fall through essential here?

[adityashaw2]

The following switch case has no break statement at the end.

https://github.com/domchristie/needles/blob/master/dist/needles-worker.js#L285-L286

    case 'set':
      this[event.data.key] = event.data.value; // <-- after this statement
    case 'record':

Is it intentional?

[domchristie]

@adityashaw2 good spot! I don't think this is intentional. Messages can only send one data.type so I don't think there's be any point to falling through. Feel free to open a pull request with the change.

[adityashaw2]

@adityashaw2 good spot! I don't think this is intentional. Messages can only send one data.type so I don't think there's be any point to falling through. Feel free to open a pull request with the change.

Thanks for the quick reply! I'll open a PR by this weekend.

[Adityashaw]

PR created.