-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ASP.NET Core documentation for 6.6.1 release #2857
Comments
- Remove unsupported notice for .NET 8. - Update package version numbers. - Remove reference to resolved issue. Resolves domaindrivendev/Swashbuckle.AspNetCore#2857.
@martincostello Thoughts on updating the templates in 8.0 as well? |
@captainsafia Do you mean the versions referenced by the templates in dotnet/aspnetcore? If so I'm happy to do that if that meets the backport bar. |
Yep, that's what I meant. I think we can make the case for it given that .NET 8 is LTS and the lack of support for net8.0 in 6.5.0 is a blocker for build-time doc gen. |
OK cool - I'll do a PR for that tomorrow 👍 |
Maybe wait with the template update until 6.6.2 is released? Or even a bit longer to give people the chance to test the new version and report bugs. |
Good point! Given the volume of changes that were merged over the past few weeks, it might be good to give things more bake time. |
Is this actually feasible? I've just learned that no template changes for existing major .NET versions can be shipped without a "patching request" path and adding features/bumping versions would not meet the bar of value vs risk. Source: dotnet/test-templates#388 (comment) And .NET 9 templates will not include Swashbuckle at all (see dotnet/aspnetcore#54599). |
It is yes feasible, yes - that's specifically what I already asked Safia already: #2857 (comment). If a member of the .NET team thinks it's a good idea, then it's at least worth opening a PR as presumably they would support the PR getting approved by their process.
We know this - but this is a conversation about .NET 8, which is supported until November 2026. |
I'll give 6.6.2 a few days to bed-in, then if we don't get any big new issues from 6.6.x I'll do the PR to the release/8.0 branch. |
Raise a pull request to edit getting-started-with-swashbuckle.md once Swashbuckle.AspNetCore 6.6.1 is released to:
See dotnet/AspNetCore.Docs#32477 (comment).
The text was updated successfully, but these errors were encountered: