Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not honour -C argument #46

Open
tinhtruong opened this issue Aug 21, 2022 · 1 comment
Open

Does not honour -C argument #46

tinhtruong opened this issue Aug 21, 2022 · 1 comment
Labels

Comments

@tinhtruong
Copy link

Hi dolmen,
Thanks for creating a great utility to make Git interaction with Github secure!
When I specified the comment (via -C argument) for my key on the comment line, it was not passed through to the underline ssh-keygen command.
I digged into the code and found that the key comment is hard-coded at https://github.com/dolmen/github-keygen/blob/release/github-keygen#L9447
My workaround is to specify my comment string at https://github.com/dolmen/github-keygen/blob/release/github-keygen#L9452 :)
I don't know about Perl so I cannot do a proper fix. :(.

@dolmen
Copy link
Owner

dolmen commented Sep 14, 2022

Thanks for the report!

Confirmed.

Here is how to reproduce:

$ mkdir tmp; HOME=$PWD/tmp perl -I../lib ../bin/github-keygen toto -C toto && cat tmp/.ssh/id_toto@github.pub ; rm -Rf tmp

dolmen added a commit that referenced this issue Sep 14, 2022
When a user was providing a custom key comment via -C, it was ignored
and our default comment always overrided it. Fixed.

#46
dolmen added a commit that referenced this issue Sep 14, 2022
@dolmen dolmen added the bug label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants