Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialization of ConceptAs<decimal> is broken #35

Open
smithmx opened this issue Apr 9, 2020 · 0 comments
Open

Serialization of ConceptAs<decimal> is broken #35

smithmx opened this issue Apr 9, 2020 · 0 comments

Comments

@smithmx
Copy link

smithmx commented Apr 9, 2020

ConceptAs is serialized as a string.

When read out, if the string was serialized under a non-invariant culture, this can result in wrong values.

e.g. 0,23 is interpreted as 23.

Using the read and write Decimal128 methods instead.
woksin added a commit that referenced this issue Apr 16, 2020
@woksin
Merge pull request #36 from dolittle-extensions/DecimalSerialization
20ef353 
Serialization of ConceptAs<decimal> is broken #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smithmx