Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a github org? #122

Open
splitbrain opened this issue Nov 25, 2023 · 1 comment
Open

use a github org? #122

splitbrain opened this issue Nov 25, 2023 · 1 comment
Assignees

Comments

@splitbrain
Copy link
Contributor

When this tool was first created, github organizations did not exist, thus a normal account was created. I wonder if it would make sense to to convert it into an organization. I think it would make administration easier. We could also globally disable the running of actions for the forked repos...

I don't know if there are any big differences in the API implementation, I would think not. Let me know what you think.

@Klap-in
Copy link
Contributor

Klap-in commented Dec 16, 2023

My first understanding is that an organisation can not commit submitted translations (on behalf of an submitter). And do a pull request. (I guess they assume real persons are behind these actions).

So probably we need still a GitHub user account for committing and pull requests? It means, we keep the burden of sharing its authentication details between us(the maintainers).

Probably we can replace the account that is used to clone the repositories into. This makes it easier for you and me to delete old or broken repositories from it.

Not sure what https://github.com/KnpLabs/php-github-api library can handle, but probably it assumes a user and not an organisation? Probably fine to let it clone into an organisation by an user triggering these actions. There I see no issues.

Can you see if an organisation still uses the "Personal access tokens > Tokens(classic)."?
https://github.com/dokuwiki/translate.dokuwiki.org/wiki/Git-interaction#tokens-for-access-the-services-user-account
If we have a user account for committing etc, then such personal acccess token for the organisation is not needed as our user dokuwiki-translate user account get the permissions granted.

Just converting the user account to an organisation means that we loss the association to the former user account dokuwiki-translate. So seems better to create a new organisation, that is named different. (or rename the useraccount first).
https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-your-personal-account/converting-a-user-into-an-organization

So my summary is now: Having an organisation makes it easier to cleanup old or broken repositories? but the user account is then still needed for committing? Could already be worth the hassle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants