Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Official Docker Image #4261

Open
splitbrain opened this issue Apr 10, 2024 · 3 comments
Open

RFC: Official Docker Image #4261

splitbrain opened this issue Apr 10, 2024 · 3 comments

Comments

@splitbrain
Copy link
Collaborator

This is a follow up to #1896 and #3381.

My attempt in #3381 is IMO the most elegant solution. However the requirement of elevated permissions to be able to use an overlay file system makes this solution impractical for real world usage.

At @cosmocode we have been relying on the Bitnami image for a while to deploy DokuWiki instances in our Kubernetes cluster. However I am not super happy with that image. We encountered problems mostly when updating containers to new DokuWiki versions: with core plugins being stale (because they had been copied into the volume) and with Bitnami internal changes that were not correctly migrated on container renewal...

In an attempt to create an image we can use instead, I came up with https://github.com/cosmocode/docker-dokuwiki

My goals were:

  • a simple image based on a stable base image (the official PHP apache image)
  • proper persistance for all user generated/modified content (including plugins, templates and configuration)
  • update safe: upgrading DokuWiki means simply updating the container, reusing the existing volume

The container should not:

  • run multiple processes
  • use any complicated process management
  • handle SSL
  • handle mail sending

All these things are better handled by properly composing multiple containers.

❓ First of all I would like to get comments on the container setup. I'm sure there are things that would be worth improving.

❓ Secondly, I wonder if it would be worth it to promote this setup to "official" status, by moving the repo to the @dokuwiki org and to auto build and publish the image on Docker hub.

@vbrozik
Copy link

vbrozik commented Apr 10, 2024

That is great that there will be an official Docker image!

I am using this compose file with DokuWiki installed in a volume:
https://github.com/vbrozik/docker-containers/tree/main/dokuwiki
The main function the compose file provides is setup/restore from a backup archive and making backups.

What do you think about including compose file(s) into your repository? For normal users it is difficult to take care of backups in the Docker environment. I think it would be really useful to include the backup functionality in the official repository. Of course anything from my repository can be used.

Regarding your Docker Image:

  • I think it would be useful to include a parameter for installing a specific DokuWiki version but I do not know how it is normally done in Docker image setups.
  • What would happen if you run the Upgrade plugin from and installed container? If it can break something there should probably be some kind of protection.

@splitbrain
Copy link
Collaborator Author

@splitbrain
Copy link
Collaborator Author

Update: the repository has been moved to the dokuwiki organization and first images have been published to docker hub.

Please report any issues you might encounter at the docker repo: https://github.com/dokuwiki/docker/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants