Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning: Trying to access array offset on value of type bool in /....../inc/Ui/Recent.php on line 165 #4235

Open
JoBongHyeon opened this issue Mar 6, 2024 · 3 comments · May be fixed by #4236
Open

Warning: Trying to access array offset on value of type bool in /....../inc/Ui/Recent.php on line 165 #4235

JoBongHyeon opened this issue Mar 6, 2024 · 3 comments · May be fixed by #4236
Labels
Bug

Comments

@JoBongHyeon
Copy link

JoBongHyeon commented Mar 6, 2024 •
edited

The problem

There is an error message.

Warning: Trying to access array offset on value of type bool in /....../inc/Ui/Recent.php on line 165

There is an error message.

I use 'Manage Access Control List'.

when I log in and open the Recent Changes page, I don't see an error message.

An error message appears when i open the Recent Changes page as a guest.

Version of DokuWiki

koas

PHP Version

8.3
@JoBongHyeon JoBongHyeon added the Bug label Mar 6, 2024
@fiwswe
Copy link
Collaborator

fiwswe commented Mar 7, 2024

Not sure about the root cause, but

dokuwiki/inc/ChangeLog/ChangeLog.php

Line 600 in a6016e3

public function getCurrentRevisionInfo()
is documented to return a bool or an array. In your case it must have returned a bool but unfortunately that case is not handled in:

dokuwiki/inc/Ui/Recent.php

Line 156 in a6016e3

protected function checkCurrentRevision(array &$info)

So yes, there is a bug here.

Does it help to change

dokuwiki/inc/Ui/Recent.php

Line 165 in a6016e3

if ($currentRevInfo['type'] == DOKU_CHANGE_TYPE_DELETE) {
to

            if (($currentRevInfo['type'] ?? null) == DOKU_CHANGE_TYPE_DELETE) {

in line 165?

@JoBongHyeon
Copy link
Author

Yes, thank you. I fixed it as you said and solved the problem.

@fiwswe
Copy link
Collaborator

fiwswe commented Mar 7, 2024

This should be closed when the issue is fixed in DokuWiki.master.

@fiwswe fiwswe reopened this Mar 7, 2024
fiwswe added a commit to fiwswe/dokuwiki that referenced this issue Mar 7, 2024
@fiwswe
Fix dokuwiki#4235
5d63c42 
Fix dokuwiki#4235

Note: This class of problem, i.e. mismatch between documented return values vs. use of them in consumers, is somewhat prevalent and very hard to find unless they happen to trigger a warning or error.

Fixing them as they come up is ok I guess but some sort of automated method to detect these would be great.
This was referenced Mar 7, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #4235 fiwswe/dokuwiki
Fix #4235 fiwswe/dokuwiki
2 participants
@fiwswe @JoBongHyeon