Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No results when searching media with empty string #4154

Closed
eduardomozart opened this issue Jan 16, 2024 · 4 comments · May be fixed by #4171
Closed

No results when searching media with empty string #4154

eduardomozart opened this issue Jan 16, 2024 · 4 comments · May be fixed by #4171
Labels
Feature

Comments

@eduardomozart
Copy link
Contributor

eduardomozart commented Jan 16, 2024 •
edited

I believe the DokuWiki Media Manager (pop-up and standalone) search should return all images when pressing Enter on search box when it's empty instead of "No image was found".
image
@Jenis07
Copy link

Jenis07 commented Jan 29, 2024

can i contribute on this?

@eduardomozart
Copy link
Contributor Author

can i contribute on this?

@Jenis07 of course. why not?

@Jenis07
Copy link

Jenis07 commented Jan 29, 2024

where this issue is located?

eduardomozart added a commit to eduardomozart/dokuwiki that referenced this issue Jan 29, 2024
@eduardomozart
Return all results when query string is blank on media manager
a9720da 
fixes dokuwiki#4154
@eduardomozart eduardomozart mentioned this issue Jan 29, 2024
Open
@eduardomozart
Copy link
Contributor Author

eduardomozart commented Jan 29, 2024 •
edited

Hello @Jenis07, I've updated this issue description to include an image of the search box on Media Manager, but I decided to troubleshoot this issue further and I was able to detect the code used to search media and patch it on PR #4171. Thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return all results when query string is blank on media manager eduardomozart/dokuwiki
3 participants
@Klap-in @eduardomozart @Jenis07