[d3d9] Handle mismatching vertex layout and vbo strides #3921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K0bin
force-pushed
the
finalfantasy-fix
branch
2 times, most recently
from
e61584d
to
230c169
Compare
|
This seems like a mess |
K0bin
force-pushed
the
finalfantasy-fix
branch
2 times, most recently
from
a98f0d3
to
6e98206
Compare
|
I pushed an updated version of this PR that should hopefully be a bit easier to read. It's still quite complex because we have to be robust against going out of bounds but it's a bit less messy now in my opinion. |
PatrickvL
reviewed
May 18, 2024
PatrickvL
reviewed
May 18, 2024
PatrickvL
reviewed
May 18, 2024
doitsujin
reviewed
May 23, 2024
... and handle mismatching vertex sizes and vertex strides.
doitsujin
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3919