Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style="padding-left: 24px;" in <body> #25

Open
EvgenyOrekhov opened this issue May 23, 2020 · 4 comments
Open

style="padding-left: 24px;" in <body> #25

EvgenyOrekhov opened this issue May 23, 2020 · 4 comments

Comments

@EvgenyOrekhov
Copy link
Contributor

Hard-coded style="padding-left: 24px;" in <body> interferes with visual appearance of the page.

image

@dohliam
Copy link
Owner

dohliam commented May 23, 2020

This is a bit tricky -- the padding is there because quite a few of the themes have zero padding by default, making the body text flush with the left margin (for example, Cardinal and Caramel). For most of the other themes, the body text is either centred or otherwise unaffected by the small amount of padding.

Having said that, turning off the padding (using the Firefox dev console) does not seem to have any effect on Holiday CSS at a number of different screen sizes I tried, so perhaps you were able to fix this already?

@EvgenyOrekhov
Copy link
Contributor Author

For some reason turning it off via the dev console doesn't remove the padding. Tried both in Firefox and in Chrome.

If a theme has zero padding, then that's how the author intended it to look. I think the switcher should not try to "fix" paddings and whatnot.

@brennanbrown
Copy link

brennanbrown commented Nov 3, 2020

@EvgenyOrekhov, it seems as though the reason you can't remove the padding is because it's being created by the js file on line 53:

  document.body.style.paddingLeft = "24px";

I agree that it should be removed, or at least equal padding should be added to the right for symmetry.

@EvgenyOrekhov
Copy link
Contributor Author

or at least equal padding should be added to the right for symmetry.

Switcher should not mess with the paddings at all. Theme's paddings should be respected and preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants