Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datetime columns are not properly formatted to be recognizes as datetime #17

Open
n8henrie opened this issue Mar 19, 2021 · 0 comments · May be fixed by #18
Open

Datetime columns are not properly formatted to be recognizes as datetime #17

n8henrie opened this issue Mar 19, 2021 · 0 comments · May be fixed by #18

Comments

@n8henrie
Copy link

Currently, the datetimes are formatted in a way that is not recognized by datasette-vega for plotting with a Date/time type for the axis.

For example, if you have datasette running locally with datasette-vega installed and have a database that includes resting heart rate:

http://localhost:8001/healthkit/rRestingHeartRate#g.mark=line&g.x_column=startDate&g.x_type=temporal&g.y_column=value&g.y_type=quantitative

The plot is blank unless you choose Label as the type for the date data.

The startDate (and creationDate and endDate) columns appear like: 2019-11-14 18:22:18 -0700

If instead the format for this column is changed slightly: 2019-11-14T18:22:18-07:00 they are recognized as proper dates and the charting works as expected.

I have a PR that addresses this issue, will submit shortly.

@n8henrie n8henrie linked a pull request Mar 19, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant