Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions do not support double quoted strings #276

Open
StayWithMeSenpai opened this issue Mar 19, 2021 · 3 comments
Open

Functions do not support double quoted strings #276

StayWithMeSenpai opened this issue Mar 19, 2021 · 3 comments
Labels

Comments

@StayWithMeSenpai
Copy link

When calling functions with a string thats using " instead of ', its still adding the , even in a string

example:
plz console.loge with 'very truth such belief wow' -> console.log('very truth such belief wow');

plz console.loge with "very truth such belief wow" -> console.log("very, truth, such, belief, wow");

@AnEmortalKid
Copy link
Member

Ah yep, the problem currently is with the tokenizer since it only supports ' strings. I'll see how feasible it is to add support for "

@AnEmortalKid AnEmortalKid changed the title Functions Functions do not support double quoted strings Mar 20, 2021
@AnEmortalKid
Copy link
Member

I have something partially working here: https://github.com/dogescript/dogescript/tree/issue-276

Though that now breaks:

very foo is new Bar with "wow","doge"

Which might not be that big of a deal to break as long as the syntax in 3.x is more strict about these argument calls.....

@vpzomtrrfrt
Copy link
Member

the spec says "Double quotes are not supported" so this seems like almost working as intended

3.x actually throws an error on this though which is nicer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants