Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R.E.P.L rewrite #189

Open
AnEmortalKid opened this issue Feb 15, 2019 · 1 comment
Open

R.E.P.L rewrite #189

AnEmortalKid opened this issue Feb 15, 2019 · 1 comment
Labels
Milestone

Comments

@AnEmortalKid
Copy link
Member

The repl works fantastically today, because we feed the given line into the parser and the parser ends up generating partial JS, which the node REPL interprets and sets us up in to the 'more lines' mode.

I think the parser taking in things one line at a time will have to change to take the program (like most things do), and we'll have to check interrogate the parser if it has reached EOF or produced a closed statement. Not entirely sure yet what the parser will return, I assume some sort of JSON with the structure and then something takes that structure and produces.

Potential refs:

@vpzomtrrfrt
Copy link
Member

For 3.x I believe this is covered, the parser and output module are exposed separately and errors caused by EOF throw an IncompleteError, which the REPL detects to prompt for more input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants