Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libdogecoinconsensus shared library #3515

Open
patricklodder opened this issue Apr 10, 2024 · 4 comments
Open

libdogecoinconsensus shared library #3515

patricklodder opened this issue Apr 10, 2024 · 4 comments
Milestone

Comments

@patricklodder
Copy link
Member

Originally posted by @daank-c in #3513 (comment)

[..] it would make me more comfortable if there was at least a label at the top of the [shared_libraries.md] document saying "this library is not actively maintained" or something to make it obvious that it's not useful at the moment. I just wouldn't want to see anyone waste their time or become confused by reading it.


For 1.15, we should either:

  1. Fix the libdogecoinconsensus library and/or docs
  2. Deprecate the libdogecoinconsensus library (can also be done in combination with the above)
  3. If neither gets done, tag the documentation as nonsensical.

I personally prefer not to resort to the third option, but this is a reminder that something has to be done.

@slightlyskepticalpotat
Copy link
Contributor

Is there anything that currently depends on the library, whether in Dogecoin Core or elsewhere? A quick GitHub search doesn't reveal anything.

@patricklodder
Copy link
Member Author

It's not used by Dogecoin Core: it's a shared library that exposes consensus-relevant functions from src/script to anyone that wants to use it. I don't know of anyone that uses it nowadays, but deprecation can trigger a response to that. We don't have to decide on this today, can give this a few months and see if anyone speaks up.

@georgeartem
Copy link

georgeartem commented Apr 26, 2024 via email

@georgeartem
Copy link

georgeartem commented Apr 26, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants