Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe switch api to Import holidays #52

Open
timo2o1o opened this issue Sep 3, 2022 · 2 comments
Open

Maybe switch api to Import holidays #52

timo2o1o opened this issue Sep 3, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@timo2o1o
Copy link
Member

timo2o1o commented Sep 3, 2022

Describe the bug
The api we use to import holidays seems a little broken. We should maybe switch to https://feiertage-api.de/

@timo2o1o timo2o1o added the good first issue Good for newcomers label Sep 3, 2022
@Jusdon
Copy link
Contributor

Jusdon commented Sep 15, 2022

The problem with this provider is that only one year can be sent per request. Unless I have overlooked something. In our case, however, we need two years in the query.

However, one could send two queries with one year each.

@timo2o1o
Copy link
Member Author

timo2o1o commented Sep 15, 2022

The problem with this provider is that only one year can be sent per request. Unless I have overlooked something. In our case, however, we need two years in the query.

However, one could send two queries with one year each.

I would rather do that, than keep having problems querying the API we use now. Another problem with the actual API is that there is no data for years before 2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants