Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envelopes API: getAttachment() has invalid return type #315

Open
jan-lewandoski opened this issue Jan 7, 2023 · 1 comment
Open

Envelopes API: getAttachment() has invalid return type #315

jan-lewandoski opened this issue Jan 7, 2023 · 1 comment

Comments

@jan-lewandoski
Copy link

Problem description

The getAttachment() method from EnvelopesApi has invalid return type:

var returnType = null; // Should not be null here

As a result, empty responses are returned with a status of 200 OK and an empty body.

The solution

It seems like the problem can be solved by changing the return type:

var returnType = Object;

I can't seem to find any dedicated type (e.g. EnvelopeAttachmentResult) but I guess it would be the right choice in this case.

I'm happy to discuss other potential solutions 👍

@acooper4960
Copy link
Contributor

acooper4960 commented Jan 17, 2023

Hello @jan-lewandoski thank you for reaching out to us regarding this issue. We will reach out to the respective API team to understand why a return type similar to the one indicated by the getAttachments endpoint is not present here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants