Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range of z-indexes for viewer is very large #21

Open
knowtheory opened this issue Aug 16, 2012 · 4 comments
Open

Range of z-indexes for viewer is very large #21

knowtheory opened this issue Aug 16, 2012 · 4 comments

Comments

@knowtheory
Copy link
Member

The fellows over at the New Jersey Star-Ledger have indicated that the viewer CSS is messing with their headers, since our z-indexes range from 0 all the way up to 20000.

Someone needs to go through all the z-index declarations in our CSS files and bump them down in a manner that keeps all of our declarations proportional, but reduces the values by either an order of magnitude (20000 to 2000, 15999 to 1599, and 1 to 1) or into simple increments of 5.

@samuelclay
Copy link
Member

And they would do well to go even higher to deal with some of the sky-high z-indexes on some publisher sites. Where do we draw the line? They probably have a fixed header. And there's no one answer that makes every site happy, is there?

@knowtheory
Copy link
Member Author

yes, that's true. That said, the viewer's behavior is a bit inconsistent (the header, scrolling pane, and footer are a lot higher than the side bar).

Embedding 3rd party styles is always going to be a fraught endeavor. I'm not sure what else we can do other than provide folks with a list of where our z-indexes are set, and making sure that there aren't any !important declarations.

@jashkenas
Copy link
Member

Or hang on a sec -- I thought that z-indexes were relative to the nearest positioned parent with a z-index?

http://jsfiddle.net/xAX5R/

All we have to do is make the viewer wrapper (which should already be position:relative), z-index: 0 also. Ted -- go for it.

@samuelclay
Copy link
Member

In this case, sure, we'd want to be under their header. But in other cases, parts of their page was obstructing the viewer/search-embed, so we didn't have a z-index:0 parent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants