Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Documents can be sent with no fields at all to sign #908

Open
6 tasks done
sumitbishti opened this issue Feb 5, 2024 · 4 comments · May be fixed by #1139
Open
6 tasks done

[Bug] Documents can be sent with no fields at all to sign #908

sumitbishti opened this issue Feb 5, 2024 · 4 comments · May be fixed by #1139
Labels
apps: marketing Issues related to website or marketing app apps: web Issues related to the webapp Stale status: triage Scope to be determined type: enhancement Enhancing a existing feature

Comments

@sumitbishti
Copy link
Contributor

Issue Description

Currently we can send documents having no fields (date, name, signature, email) to get signed.

Steps to Reproduce

Upload a doc
enter title and email
do not select any fields, hit continue
it will be sent to the recipient with no fields

Expected Behavior

the doc to be sent should have at least one field(signature)

Current Behavior

No response

Screenshots (optional)

No response

Operating System [e.g., Windows 10]

No response

Browser [e.g., Chrome, Firefox]

No response

Version [e.g., 2.0.1]

No response

Please check the boxes that apply to this issue report.

  • I have searched the existing issues to make sure this is not a duplicate.
  • I have provided steps to reproduce the issue.
  • I have included relevant environment information.
  • I have included any relevant screenshots.
  • I understand that this is a voluntary contribution and that there is no guarantee of resolution.
  • I want to work on creating a PR for this issue if approved
@sumitbishti sumitbishti added the type: bug Something isn't working label Feb 5, 2024
@maige-app maige-app bot added Reliability status: triage Scope to be determined labels Feb 5, 2024
@ElTimuro
Copy link
Member

ElTimuro commented Feb 5, 2024

Yes, this behavior is not correct/ wanted. A solution we already discussed internally:
Allowing documents with no fields, but forcing the user to place one during signing (with optional fields like date, etc.)

@Mythie let me know if we should do this ourselves our accept contributions
@sumitbishti would you be interested in working on this if we accept contributions on this? Thanks for reporting this so far :)

@dguyen dguyen added type: enhancement Enhancing a existing feature apps: web Issues related to the webapp apps: marketing Issues related to website or marketing app and removed type: bug Something isn't working Reliability labels Feb 6, 2024
@sumitbishti
Copy link
Contributor Author

Yes, I would be interested in working on this for sure.

@hiteshwadhwani
Copy link
Contributor

If this issue is not fixed yet I would like to work on this

@ElTimuro
Copy link
Member

ElTimuro commented Feb 13, 2024

@Mythie afaik we are not internally working on this, right? Should have take submissions for this?

My suggested solution:

  • Sending without any field is still possible
  • The recipient can place signatures and other fields freely as they choose
  • Freely adding fields as the signer should also be possible for documents with fields. If this is possible should be configurable under "Avanced" before Document sending

@github-actions github-actions bot added the Stale label May 13, 2024
@dguyen dguyen linked a pull request May 22, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps: marketing Issues related to website or marketing app apps: web Issues related to the webapp Stale status: triage Scope to be determined type: enhancement Enhancing a existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants