Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some data collectors are gone #606

Open
garak opened this issue Dec 10, 2019 · 14 comments
Open

Some data collectors are gone #606

garak opened this issue Dec 10, 2019 · 14 comments
Assignees
Projects

Comments

@garak
Copy link

garak commented Dec 10, 2019

I see that version 4 dropped PrettyDataCollector and StandardDataCollector, and added CommandDataCollector.
Unfortunately, I can't find any mention of this in CHANGELOG-4.0 nor in UPGRADE-4.0.
What is the supposed upgrade path? Can we add some instructions?

@alcaeus
Copy link
Member

alcaeus commented Dec 12, 2019

I apologise for the delayed response, this issue managed to hide in between my notifications.

The PrettyDataCollector previously attempted to reproduce commands to be used in the MongoDB shell for anything that was executed through doctrine/mongodb. With the new APM-based logging functionality, we're no longer looking at such operations, but only at commands (hence CommandDataCollector). These will always be run through db.runCommand(...) in the MongoDB shell, which is also why we've opted to not add a data collector that changes the output.

The CommandDataCollector prints the command document as it was sent to the server. You can copy that and directly paste it into the shell to reproduce its results.

It could very well be that I forgot to mention this in the documentation. I won't get to it until next week, but I'll gladly review and merge a PR to the 3.6 or 4.0 branch depending on where we introduced the upgrade files. Thanks for raising this issue!

@markitosgv
Copy link

Im trying executing some profiling commands, but it fails, ie:

db.runCommand({"find":"Purchases","filter":{"_id":{"$in":[{"$oid":"5de92135ebd06910835a25c7"}]}}})

error: cannot nest $ under $in

or

db.runCommand({"find":"Purchases","filter":{"_id":{"$oid":"5de92135ebd06910835a25c7"}}})

error: unknown operator: $oid

Before PrettyDataCollector worked nice

@alcaeus
Copy link
Member

alcaeus commented Dec 18, 2019

Ah. The $oid portion is how ObjectID is serialised. This won't work in the MongoDB shell and needs to be changed. I'll see what I can do there 👍

@stale
Copy link

stale bot commented Jan 17, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues that have not seen any activity in 30 days label Jan 17, 2020
@markitosgv
Copy link

Any new idea about this @alcaeus ?

@stale stale bot removed the Stale Issues that have not seen any activity in 30 days label Jan 17, 2020
@alcaeus
Copy link
Member

alcaeus commented Jan 17, 2020

Sorry, I haven't gotten to it at all for now.

@stale
Copy link

stale bot commented Feb 16, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues that have not seen any activity in 30 days label Feb 16, 2020
@stale stale bot closed this as completed Feb 23, 2020
@markitosgv
Copy link

markitosgv commented Jun 14, 2020

any updates about change $oid? thanks!

@malarzm
Copy link
Member

malarzm commented Jun 14, 2020

I'll reopen this for when @alcaeus is back

@malarzm malarzm reopened this Jun 14, 2020
@stale stale bot removed the Stale Issues that have not seen any activity in 30 days label Jun 14, 2020
@stale
Copy link

stale bot commented Jul 15, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues that have not seen any activity in 30 days label Jul 15, 2020
@malarzm malarzm removed the Stale Issues that have not seen any activity in 30 days label Jul 15, 2020
@stale
Copy link

stale bot commented Aug 15, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues that have not seen any activity in 30 days label Aug 15, 2020
@stale stale bot closed this as completed Aug 22, 2020
@malarzm malarzm removed the Stale Issues that have not seen any activity in 30 days label Aug 22, 2020
@malarzm
Copy link
Member

malarzm commented Aug 22, 2020

Bad bot

@malarzm malarzm reopened this Aug 22, 2020
@stale
Copy link

stale bot commented Sep 22, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues that have not seen any activity in 30 days label Sep 22, 2020
@alcaeus alcaeus self-assigned this Sep 22, 2020
@stale stale bot removed the Stale Issues that have not seen any activity in 30 days label Sep 22, 2020
@alcaeus alcaeus added this to the 4.2.3 milestone Sep 22, 2020
@markitosgv
Copy link

reopen please :)

@alcaeus alcaeus added this to 4.x in Roadmap Oct 21, 2020
@franmomu franmomu modified the milestones: 4.3.1, 4.4.1 Nov 30, 2021
@IonBazan IonBazan modified the milestones: 4.4.1, 4.5.0 Nov 30, 2021
@franmomu franmomu modified the milestones: 4.5.0, 4.6.0 Jun 26, 2022
@franmomu franmomu modified the milestones: 4.6.0, 4.7.0 Jul 26, 2023
@alcaeus alcaeus removed this from the 4.7.0 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

6 participants