Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using change_column_null can make the migration fail #33

Open
dorianmarie opened this issue Dec 14, 2020 · 0 comments
Open

using change_column_null can make the migration fail #33

dorianmarie opened this issue Dec 14, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@dorianmarie
Copy link

I had a migration which was:

add_column :video_chats, :source, :string, default: 'patient', null: false

And it added the column, added the default but failed when adding the null constraint.

Maybe it should add a CONSTRAINT CHECK instead?

See https://github.com/doctolib/doctolib/pull/40650
@rchoquet rchoquet added the enhancement New feature or request label Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rchoquet @dorianmarie