Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker-compose config's "depends_on" does not comply with docker stack deploy since its no longer a YAML list #8287

Closed
ProteanCode opened this issue Apr 15, 2021 · 7 comments

Comments

@ProteanCode
Copy link

Simply put I have newest docker & docker-compose running on Ubuntu 18.04

Because of some incompatibilities or other quirks I mostly used following command to generate a stack file for Docker Swarm

docker-compose -f docker-compose.stack.yml config > stack.yml && docker stack deploy -c stack.yml foo && rm stack.yml

This will no longer work since depends_on has changed from list to ie.

  nginx:
    depends_on:
      php:
        condition: service_started

I guess I will have to downgrade docker-compose version

@ProteanCode
Copy link
Author

Actually does swarm care about depends_on? I may get rid of that but this may be a glitch for swarm project then

@wojiushixiaobai
Copy link

wojiushixiaobai commented Apr 30, 2021

version: '2.4'
Using version: '3' will cause this problem

@stale
Copy link

stale bot commented Oct 30, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 30, 2021
@sebastianrothe
Copy link

still not fixed

@stale
Copy link

stale bot commented Oct 31, 2021

This issue has been automatically marked as not stale anymore due to the recent activity.

@stale stale bot removed the stale label Oct 31, 2021
@ndeloof
Copy link
Contributor

ndeloof commented Nov 1, 2021

docker stack deploy doesn't conform to the compose specification, nothing we can do within compose project to fix this.

Also, why do you need to pre-process your compose file with docker-compose config? docker stack deploy supports parsing compose file the same way

@ProteanCode
Copy link
Author

ProteanCode commented Nov 1, 2021

docker stack deploy doesn't conform to the compose specification, nothing we can do within compose project to fix this.

Also, why do you need to pre-process your compose file with docker-compose config? docker stack deploy supports parsing compose file the same way

docker stack deploy does not parse the .env file that is inside the dir with compose file

moby/moby#29133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants