-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epic: "compose run" should support every "docker run" option #363
Comments
👍 |
👍 |
1 similar comment
👍 |
Agree in principle, but since we're already using the |
A common pattern for this kind of thing is to support passing args after a So Would pass This is nice because
|
Actually, since we don't shell out to the docker client and talk to the API, this won't hold true unfortunately. |
Fair enough, you still have to do some translation to the docker-py args, but from what I've seen they seem to be pretty similar. docker-py may not support every argument yet either. |
To be more specific I think Especially since I need |
👍 We also need this, especially to pass environment variables to the docker run command! |
these options need to be specified within fig.yml and be overridden with |
good idea! - or like @dnephin suggested, use a double-slash separators for directly passed parameters e.g: fig up -- -cpu 2 -memory 128m |
I think some of the biggest ones are memory, CPU, and ENV settings. These tend to be the ones that change the most for one off commands and tasks |
If anyone fancies implementing |
So, what is the status of this request? Currently using fig without full Docker options is very limited. |
@flycatr which options are missing that you need? |
This would be extremely useful.
|
Restart policy would be quite welcome yes. |
@saidimu @thaJeztah Thanks! If you have the time to write a patch, that would be very much appreciated. ;) |
@bfirsh I'm looking for
|
I'm currently playing around with 'fig scale' and would find it useful if there was support for the docker '--publish-all' option. |
|
docker-compose does not support the new --shm-size option |
Another thing which is really important here is --rm=false which CircleCI needs to not print errors all over the place. You can't remove containers on CircleCI (for some reason relating to permissions I think) so therefore you can't use docker-compose to build containers satisfactorily. |
Will this, by way of association, work with This currently is odd since in the docker-compose.yml it is possible to set which cpu to use. |
@Nokel81 |
@thaJeztah Then how would I allow |
I'd love to be able to mount a |
Work on |
Update state of branches and slack link
Hi, Any update on the |
|
|
I want to use resource constraints without a swarm. How can I do that in my version: "3" docker-compose.yml? https://docs.docker.com/compose/compose-file/#resources deploy:
resources:
limits:
memory: "1G"
cpus: "0.01" WARNING: Some services ... use the 'deploy' key, which will be ignored. Compose does not support 'deploy' configuration |
@jasonben did you find an answer for this? |
|
Can we setup signal proxying as a thing? EDIT: I have given this more thought and it seems like we could just install the signal handler to forward whatever signals we could capture on either platform to the container ID via the |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it had not recent activity during the stale period. |
fig run
should support every option ofdocker run
, just referring to a service instead of an image.Todo (in rough priority order)
-u
Provide user override option on command line #971--entrypoint
Add support for entrypoint to "fig run" #511-w
Adds -w WORKDIR option to fig run. #332-p
Support mapping specific ports in "docker-compose run" #1709-v
--cpuset
--memory
--env-file
--net
--memory-swappiness
support --memory-swappiness #2383--volumes-from
"docker-compose run" should support--volumes-from
#1769The text was updated successfully, but these errors were encountered: