Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortuct keys are not working for text classification #453

Closed
mathrb opened this issue Nov 22, 2019 · 3 comments
Closed

Shortuct keys are not working for text classification #453

mathrb opened this issue Nov 22, 2019 · 3 comments
Labels
bug Something isn't working question Further information is requested
Projects
v1.0.2

Comments

@mathrb
Copy link

mathrb commented Nov 22, 2019 •
edited

Hello,

First of all, great work!

I noticed a difference on text classification between the online demo (previous dashboard) and last release demo (new dashboard). The shortcuts are not working anymore, pressing N or P key does not change the label (Sentiment Analysis project). The arrow keys to navigate between documents work.

Not familiar with Vue.js, can't figure where this is happening.

Have you experienced the same behabior?

King regards

EDIT: I tried using Firefox 70 & chrome 78
@mathrb mathrb changed the title Shortucts key are not working for text classification Shortuct keys are not working for text classification Nov 22, 2019
@icoxfog417 icoxfog417 added the question Further information is requested label Nov 22, 2019
@Hironsan
Copy link
Member

I confirmed the problem. I will add it taks list.
Thanks!

@icoxfog417 icoxfog417 added the bug Something isn't working label Nov 22, 2019
@Hironsan Hironsan added this to To do in v1.0.2 Nov 22, 2019
@Jiaxin-Pei
Copy link

Facing the same issue!

Hironsan added a commit that referenced this issue Nov 25, 2019
@Hironsan
Merge pull request #456 from chakki-works/bugfix/working-shortkey
167d657 
Enable to use shortkeys in text classification and fix #453
@mathrb
Copy link
Author

mathrb commented Nov 25, 2019

Hello Hironsan,

It is now working !

On the Sentiment Analysis demo page, there's no shortcut key, would be nice for testing purpose :)

Kind regards

@Hironsan Hironsan moved this from To do to Done in v1.0.2 Nov 26, 2019
@Hironsan Hironsan mentioned this issue Nov 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working question Further information is requested
Projects
No open projects
v1.0.2
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@icoxfog417 @mathrb @Hironsan @Jiaxin-Pei