Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve doc for Java #68

Open
olijaun opened this issue Sep 30, 2019 · 3 comments
Open

Improve doc for Java #68

olijaun opened this issue Sep 30, 2019 · 3 comments

Comments

@olijaun
Copy link

olijaun commented Sep 30, 2019

As a beginner with AKKA (using javadsl) I had some troubles sending the "ClearJournal" message to the in-memory-store. Currently it seems not to be possible to do this with a proper Java-API. I had to use some strange "$"-classes (at least for me because I don't know Scala).

The documentation should be improved with a "full" example:

TestProbe tp = new TestProbe(akkaSetup.actorSystem());
StorageExtensionImpl extension = (StorageExtensionImpl) StorageExtension.get(akkaSetup.actorSystem());
ActorRef actorRef = extension.journalStorage();

InMemoryJournalStorage.ClearJournal$ myvar = InMemoryJournalStorage.ClearJournal$.MODULE$;
        tp.send(actorRef, myvar);
        tp.expectMsg(new Status.Success(""));

Also I'm not really sure about the versions. In maven I have 2.5.15.2 configured. However the latest version in github is 2.5.15.1.

@olijaun olijaun changed the title Improve Doc for Java Improve doc for Java Sep 30, 2019
@BeatSager
Copy link
Contributor

BeatSager commented Sep 30, 2019

Using scala case objects in java code is quite ugly. Instead of adding this to the documentation I would propose to solve this in the api by either not use case objects but empty case classes (will be warned in scala) or add some functions returning this objects.

@olijaun
Copy link
Author

olijaun commented Nov 12, 2019

@BeatSager Yes, sure. I just think that until it is solved in the API the next best thing is to have it in the doc ;-)

@BeatSager
Copy link
Contributor

@dnvriend I could change the api and prepare a pull request. What do you think about it?
Do you already know when you plan to go drop support for akka 2.4 #57 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants