Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] TorchData Pytorch support #7362

Open
mfbalin opened this issue Apr 27, 2024 · 4 comments
Open

[GraphBolt] TorchData Pytorch support #7362

mfbalin opened this issue Apr 27, 2024 · 4 comments
Assignees
Labels
help wanted Need helps from the community

Comments

@mfbalin
Copy link
Collaborator

mfbalin commented Apr 27, 2024

馃敤Work Item

IMPORTANT:

  • This template is only for dev team to track project progress. For feature request or bug report, please use the corresponding issue templates.
  • DO NOT create a new work item if the purpose is to fix an existing issue or feature request. We will directly use the issue in the project tracker.

Project tracker: https://github.com/orgs/dmlc/projects/2

Description

pytorch/pytorch#124907 (comment)

Here, torch developers say that future versions of pytorch may not support torchdata properly. It might become a problem to support later PyTorch versions.

@mfbalin mfbalin added Work Item Work items tracked in project tracker help wanted Need helps from the community and removed Work Item Work items tracked in project tracker labels Apr 27, 2024
@Rhett-Ying
Copy link
Collaborator

Previously we're trying to deprecate torchdata with torch.utils.data for datapipe-related operations as active development and release of torchdata have been paused(mentioned here).

So for now, both pytorch and torchdata team are deprecating torchdata?

@mfbalin
Copy link
Collaborator Author

mfbalin commented Apr 28, 2024

I don't know the exact details. We need to look into it as it is a crucial dependency.

@mfbalin
Copy link
Collaborator Author

mfbalin commented Apr 28, 2024

https://discuss.dgl.ai/t/importerror-cannot-import-name-dill-available-from-torch-utils-data-datapipes-utils-common/4363/2 might be a related problem, I saw a PR in torch repo that fix this issue.

@frozenbugs
Copy link
Collaborator

The way we implement DataLoader (https://github.com/dmlc/dgl/blob/658b2086b09bbd76c3d3f488af2b155a1c921052/python/dgl/graphbolt/dataloader.py#L79C7-L79C17) right now isn't perfect. It makes a lot of assumption that might cause problems later. Once those problems hit, we should redesign it. We held off because the torch.data already does a good job, but if we have to, we'll tackle it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Need helps from the community
Projects
None yet
Development

No branches or pull requests

3 participants