Path prefix for bucket key #4
Comments
|
Can you assign this to me for Hacktober please? :-) |
|
Assigned! If you run across any other ways to improve anything, I'm all ears ... project's more than over-due some love 😅 |
|
How do you think prefixes should handle commit refs? Currently we always upload to the root of the bucket and keep track of whether there are any new commits by using a git ref. If you run This might be fine if the intended use is to only ever use a single prefix per git repo, though I'd argue we might want to add a switch/some docs on the git invocations to ignore/reset the ref to allow existing users to move into a folder. The other option is to create a per-prefix ref and use this to track the changes. Would allow pushing branches to prefixes, etc. but perhaps that is overkill for this tool/outside the scope of this feature? EDIT: Also means if you add a prefix where you didn't have one previously you will end up with only the updated files in the prefix directory, which I think is pretty confusing behaviour. |
Add new option -p to set a prefix file path which will cause uploaded files to go to a subfolder of the S3 bucket, allowing for multiple git repos to be hosted in a single bucket. This works well for new repos but will currently have some pretty unexpected handling if you've already used git-s3-push. Will need to either ignore the ref when changing prefix or create a per-prefix ref.
Add new option -p to set a prefix file path which will cause uploaded files to go to a subfolder of the S3 bucket, allowing for multiple git repos to be hosted in a single bucket. This works well for new repos but will currently have some pretty unexpected handling if you've already used git-s3-push. Will need to either ignore the ref when changing prefix or create a per-prefix ref.
Add new option -p to set a prefix file path which will cause uploaded files to go to a subfolder of the S3 bucket, allowing for multiple git repos to be hosted in a single bucket. This works well for new repos but will currently have some pretty unexpected handling if you've already used git-s3-push. Will need to either ignore the ref when changing prefix or create a per-prefix ref.
…ucket-key #4 path prefix for bucket key
|
Have merged this. Will do some more extensive testing over the weekend but it's looking good so far! |
Add an option to specify a path prefix for the bucket key ie. allow pushing git repos into sub-folders of S3 buckets. This would allow, for example, storage of multiple git repos in a single S3 bucket.
The text was updated successfully, but these errors were encountered: