Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on prefix trees #2

Open
Anisha7 opened this issue Dec 11, 2019 · 0 comments
Open

Feedback on prefix trees #2

Anisha7 opened this issue Dec 11, 2019 · 0 comments

Comments

@Anisha7
Copy link

Anisha7 commented Dec 11, 2019

Great job on completing the prefix tree!

  • You can further challenge yourself by working on time and space complexities for each prefix tree method. You would be expected to do this in interviews, and it would be good practice :)
  • Your complete and size tests are failing. Are you checking for duplicate insert when updating your size property? For your complete function, make sure you are finding all words in your tree that complete the given prefix.
  • Your contains method is failing tests. This method should only be returning true for words that are in the tree and terminal.
  • Your strings method is failing tests. For test_strings, try adding print(tree_strings, input_strings) and see what is being added to both. It might give you some direction for debugging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant