Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] GraphQL: This query requests up to 506,650 possible nodes which exceeds the maximum limit of 500,000. #342

Closed
sdwheeler opened this issue Feb 29, 2024 · 5 comments · Fixed by #348
Labels
bug Something isn't working

Comments

@sdwheeler
Copy link

Describe the bug
Receiving an error at startup. Also, the error display causes the layout in the terminal to be corrupted.

The log seems to show that the error occurs when querying the PRs for the MicrosoftDocs/PowerShell-Docs-DSC repo. That repo only has a total of 246 issues and PRs.

To Reproduce
Start dash with my configuration. The problem is intermittent.

Screenshots
I will add a screenshot when the error occurs again.

Desktop (please complete the following information):

  • OS: Windows 11
  • gh-dash version 3.14.0
    commit: bf3764c
    built at: 2024-02-17T17:02:04Z
    built by: goreleaser
    goos: windows
    goarch: amd64
  • debug.zip - contains the debug log and my configuration file
@sdwheeler sdwheeler added the bug Something isn't working label Feb 29, 2024
@sdwheeler
Copy link
Author

Here is a screenshot showing the error and how it breaks the layout in the terminal.
image

Interesting to note, I only see this error on screen when I run dash without the --debug switch. If I use --debug, the error is in the error log but not on screen.

@KyleKing
Copy link

I'm also having the same issues with both v3.14.0 and HEAD, but not when downgrading to v3.13.1:

gh extension install dlvhdr/gh-dash --pin='v3.13.1' --force

@dlvhdr
Copy link
Owner

dlvhdr commented Mar 15, 2024

You can use HEAD until I release a new version, #348 should fix the problem.
For anyone that doesn't want to use HEAD, you can set a lower limit in your config:

prSections:
  - title: My PRs
    layout:
      lines:
        hidden: true
    filters: author:@me
    limit: 5

@KyleKing
Copy link

Thanks!!

On the workaround, shouldn't default.prsLimit be used when set?
https://github.com/KyleKing/dotfiles/blob/67371a68ccc550a1b336bd4d6f1484ee1ee7841d/dot_config/gh-dash/config.yml#L33

@dlvhdr
Copy link
Owner

dlvhdr commented Mar 15, 2024

Yeah it should fallback to that of the section doesn't define one. I guess even with 50 prs, I fetch too many nodes (a pr includes comments, review threads and a whole lot more nodes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants