Terminal corrupted if keystroke help is open during subprocess

[annettejanewilson]

Describe the bug
If the keystroke help pane (from pressing ?) is open when a subprocess is spawned, then on completion of the subprocess, the terminal layout is corrupted.

To Reproduce
Steps to reproduce the behavior:

1. Start gh dash.
2. Switch to any tab with PRs listed.
3. Press ? to show the keystroke help panel.
4. Press d to show a diff of the current PR.
5. Press q to quit from the diff viewer.
6. Press ? to hide the keystroke help panel.

Expected behavior

• The window shown after step 5 should be the same as the one shown after step 3 - the list of PRs with a help pane at the bottom.
• The window shown after step 6 should be the same as after step 2 - the list of PRs with no help pane.

Actual behaviour

• The window shown after step 5 is missing the top 9 or so lines, including the tabs, the search box, the column headings and at least the first PR in the list.
• The window shown after step 6 continues to be missing the top 9 or so lines. While the help pane disappears, some text from the bottom of the pane is not immediately erased.

Desktop

• OS: macOS Ventura 13.5
• Terminal: iTerm2

I am not using tmux, screen or similar tools.

[danjones1618]

I'm also getting this issue

[lomby92]

Same issue for me.

OS: Fedora Linux 38 (Sway)
Kernel: 6.8.7-100
Shell: zsh
WM: sway
Terminal: foot