Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: better error messages #11

Open
pengnam opened this issue Mar 10, 2021 · 2 comments
Open

feature request: better error messages #11

pengnam opened this issue Mar 10, 2021 · 2 comments

Comments

@pengnam
Copy link
Collaborator

pengnam commented Mar 10, 2021

As one of two users of SOC print, I believe my opinion carries some weight.

The new SOC print expects the users to indicate the duplex along with the printer name. I failed to do so and it does not indicate that the printer I specified is not in printer list. Please fix.
To recreate, the command I used is below.

image

@pengnam
Copy link
Collaborator Author

pengnam commented Mar 10, 2021

@dlqs For your information.

@dlqs
Copy link
Owner

dlqs commented Mar 11, 2021

Hello, valued customer! Thank you for contacting support@socprint.sh. Since our dear PM is on marital leave (SOCPrint's benefits include 3 days marital leave and 21 days paid vacation), I will take this issue.

According to the docs by our printer provider, a printer name with no suffix e.g. psts should work. But upon triage, it does indeed appear that only psts-dx works.

Since our all-knowing, omnipotent printer provider couldn't possibly have misdocumented things, I suggest the following:

  1. Change list command regex at https://github.com/dlqs/SOCprint/blob/master/socprint.sh#L227 to exclude printers without suffixes
  2. Change the print command to use the list command to list valid printqueues and,
  3. Flash a warning if the printqueue doesn't exist in said list (but still continue with the rest of the command)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants