Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wishlist in Dawn Theme 5.0.0 #34

Open
shopify-dawn opened this issue May 18, 2022 · 5 comments
Open

Wishlist in Dawn Theme 5.0.0 #34

shopify-dawn opened this issue May 18, 2022 · 5 comments

Comments

@shopify-dawn
Copy link

Hi, I followed all the steps, but it didn't work.
I can't even see the heart icon.
What should I add or remove to the code so it work

Note: I'm using the latest Dawn version 5.0.0

Thank you.

@dlerm
Copy link
Owner

dlerm commented May 21, 2022

@shopify-dawn can you try adding explicit width and height attributes to the svg element inside the file icon-heart.liquid?

Example:

<svg width="20" height="20" ...></svg>

@shopify-dawn
Copy link
Author

On top of each product, appear a big heart. Some are not clickable and others take you to the product page
image

@shopify-dawn
Copy link
Author

Note: When I change the numbers, the stroke-width does change, but the heart size stays the same.

@dlerm
Copy link
Owner

dlerm commented May 22, 2022

@shopify-dawn Do you have any site specific styling applying to buttons or SVGs that would cause the SVG to be positioned outside the button? The button is the only part that has functionality attached. The SVG is just a visual element.

@shopify-dawn
Copy link
Author

No I don't. I used the wishlist in a new unstyled dawn theme to see if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants