Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Type forced to Terrain when bbox provided to get_map() #324

Open
datawookie opened this issue Aug 5, 2021 · 0 comments
Open

Map Type forced to Terrain when bbox provided to get_map() #324

datawookie opened this issue Aug 5, 2021 · 0 comments

Comments

@datawookie
Copy link

datawookie commented Aug 5, 2021

Hi David!

Love using this package. However, I've found something odd with the version currently on CRAN.

In the code for get_map():

if (is.numeric(location) && length(location) == 4) {
    location_type <- "bbox"
    location_stop <- FALSE
    source <- "stamen"
    maptype <- "terrain"
    # ... other code
}

It seems like if the location is specified by a bounding box then:

  1. the source is changed to Stamen (cool, this makes sense!) but
  2. the map type is forced to "terrain".

The second item doesn't really make sense. What about the other map types available from Stamen, like "terrain-lines"? Would it not be better to just check here whether the requested (or default) map type is valid for Stamen?

Thanks for considering this and also thanks for your work in maintaining this great package.

Best regards, Andrew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant