Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring all Java classes to Kotlin #55

Open
jeryini opened this issue Feb 12, 2022 · 2 comments
Open

Refactoring all Java classes to Kotlin #55

jeryini opened this issue Feb 12, 2022 · 2 comments

Comments

@jeryini
Copy link

jeryini commented Feb 12, 2022

Hello @dji-dev @DJI-William !

We're using this UX-SDK and we have cloned the repository due to introducing some things specific to our needs. We've also refactored/moved some classes from Java to Kotlin due to less overhead when using some features such as sealed classes. We're now fetching your changes upstream and trying to incorporate them in our cloned repo. But it would be much easier if all classes in Java would also be converted to Kotlin in this repository. During our conversion, we did not notice any issues by doing simple conversion from Java to Kotlin class. Is there something we can help to make this repository use only Kotlin? For example, would you accept a PR that would contain the complete conversion?

@Michael-DJI
Copy link
Contributor

@jeryini we could accept any PR which truelly refine the current code, but please create separate PR for reviewing, the first one could be about "introducing some things specific to our needs" the second one is about "refactored/moved some classes from Java to Kotlin"

@jeryini
Copy link
Author

jeryini commented Feb 20, 2022

Hello @Michael-DJI

Great, nice to hear that you would consider accepting that kind of changes. Sure, the first PR would be only to convert existing Java classes to Kotlin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants