Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more simulations to the FACS autovalidator #35

Open
3 tasks
djgroen opened this issue Jul 19, 2023 · 4 comments
Open
3 tasks

Add more simulations to the FACS autovalidator #35

djgroen opened this issue Jul 19, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request future-proofing good first issue Good for newcomers
Milestone

Comments

@djgroen
Copy link
Owner

djgroen commented Jul 19, 2023

  • Add 2-4 extra simulations to the autovalidator.
  • Check if validation data files are present.
  • Do a test run using fabsim archer2 validate_facs:cores=24 and see what the error is.

The additional simulation configurations should be added here: https://github.com/djgroen/FabCovid19/tree/master/config_files/facs_validation/SWEEP

@djgroen djgroen added enhancement New feature or request good first issue Good for newcomers future-proofing labels Jul 19, 2023
@djgroen djgroen added this to the FACS 2.0 milestone Jul 19, 2023
@arindamsaha1507
Copy link
Collaborator

Hi @djgroen

Could you check if the command is correct?

Do you mean this one instead?

https://github.com/djgroen/FabCovid19/blob/685c703398e697ec78304486b81b0e47edf7c268/VVP/facs_VVP_ensemble_validation.py#L67

@djgroen
Copy link
Owner Author

djgroen commented Jul 24, 2023

No, I meant this one actually:

fabsim archer2 validate_facs:cores=24

@arindamsaha1507
Copy link
Collaborator

Seemingly there is no task called validate_facs... Getting the error

RuntimeError: The request task facs_validate is not available!!

@djgroen
Copy link
Owner Author

djgroen commented Jul 24, 2023

@arindamsaha1507

Look at line 93...

@load_plugin_env_vars("FabCovid19")
def validate_facs(cores=1, skip_runs=False, label="", sif_mode=False, sif_dir="", **args):```

@djgroen djgroen assigned arindamsaha1507 and unassigned djgroen Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request future-proofing good first issue Good for newcomers
Projects
Status: In Progress
Development

No branches or pull requests

2 participants