Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot see more than 64 copies of Ribbon example particle effect #321

Closed
jakkos-net opened this issue May 13, 2024 · 1 comment · Fixed by #328
Closed

Cannot see more than 64 copies of Ribbon example particle effect #321

jakkos-net opened this issue May 13, 2024 · 1 comment · Fixed by #328
Labels
C - bug Something isn't working

Comments

@jakkos-net
Copy link

Crate versions
bevy version: 0.13.2
bevy_hanabi version: 2da6d8d

Describe the bug

Spawning 100 copies of the particle effect bundle from the Ribbons example leads to only 64 being visible

Expected behavior

100 instances of the particle effect are visible

To Reproduce

https://github.com/jakkos-net/bevy_hanabi_64_issue

Screenshots

image
@djeedai djeedai added the C - bug Something isn't working label May 18, 2024
djeedai added a commit that referenced this issue May 19, 2024
@djeedai
Fix indirect dispatch count when groups are used
dcf62d8 
Fix the number of workrgoups dispatched in the indirect dispatch pass
when groups are used. Only the first group was counted.

Fixes #321
@djeedai djeedai mentioned this issue May 19, 2024
Merged
djeedai added a commit that referenced this issue May 19, 2024
@djeedai
Fix indirect dispatch count when groups are used (#328)
b8002e8 
Fix the number of workrgoups dispatched in the indirect dispatch pass
when groups are used. Only the first group was counted.

Fixes #321
@djeedai
Copy link
Owner

djeedai commented May 19, 2024

@jakkos-net the latest change #328 fixes it for me. Let me know and feel free to reopen if there's still any issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C - bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix indirect dispatch count when groups are used djeedai/bevy_hanabi
2 participants
@djeedai @jakkos-net