Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PermissionRequiredMixin does not check permissiosn against an object #259

Closed
ramast opened this issue Sep 1, 2014 · 2 comments
Closed
Labels

Comments

@ramast
Copy link

ramast commented Sep 1, 2014

Hey Guys,
According to guardian documentation PermissionRequiredMixin will check the permission against the object specified by the function get_object or attribute self.object if neither specified it will check if the user has the permission globally
https://pythonhosted.org/django-guardian/api/guardian.mixins.html
but when I check the code it seems this Mixin only check the global permission and never call get_object, debugging my code also proved that.
am I missing something or is this a bug?

I can fix it and upload a patch but need to verify its really a bug
Tested version: 1.2.4

@aidanlister
Copy link

For me it's checking the object permission and ignoring the fact that the user has global permissions?

@brianmay
Copy link
Contributor

No response; closing. Can be reopened if required. Also see #380.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants