Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom attributes for (inline) styles #839

Closed
nkuttler opened this issue Mar 31, 2017 · 4 comments
Closed

Support custom attributes for (inline) styles #839

nkuttler opened this issue Mar 31, 2017 · 4 comments
Labels

Comments

@nkuttler
Copy link

I need to add the amp-custom attribute to the style tag of inline css for some requests. There are issues that seem related, like #459 and #690. One easy solution for me would be to override the css_inline.html template, but I'd need to be able to pass request data into it.

The {% compress %} tag is confusing me a bit because of the undocumented (?) third argument name, but I think I should be able to modify it to pass data down to the template rendering.

Passing the template context would fix my problem, is that an acceptable approach?

I have seen there is also #294 which looks like it addressed this problem as well.

@karyon
Copy link
Contributor

karyon commented May 11, 2017

unfortunately i don't know the code well enough and can't say whether that approach is good. you are very much welcome to implement this or take the relevant parts from #294 and make a PR. can you tell me whether this is another use case for the feature requested in #690? in that case i would close it as a duplicate.

@karyon
Copy link
Contributor

karyon commented May 27, 2017

ping :)

@nkuttler
Copy link
Author

I ended up hardcoding the attribute into all templates because it's just a little invalid html, and have started a new job. Won't be able to do anything here anytime soon.

@karyon
Copy link
Contributor

karyon commented Jun 15, 2017

okay, thanks for the reply. i'll assume this is covered by #690 and close this.

@karyon karyon closed this as completed Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants