Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken in 1.10 due to option_list (Deprecated Django 1.8) #784

Closed
jvc26 opened this issue Aug 2, 2016 · 4 comments
Closed

Broken in 1.10 due to option_list (Deprecated Django 1.8) #784

jvc26 opened this issue Aug 2, 2016 · 4 comments

Comments

@jvc26
Copy link

jvc26 commented Aug 2, 2016

django_compressor appears broken in 1.10 due to the behaviour of the management command requiring BaseCommand.option_list. This has been deprecated since Django 1.8, and consequently breaks on running in 1.10:

    class Command(BaseCommand):
  File "/usr/local/lib/python3.5/site-packages/compressor/management/commands/compress.py", line 39, in Command
    option_list = BaseCommand.option_list + (
AttributeError: type object 'BaseCommand' has no attribute 'option_list'

BaseCommand.add_arguments() should be used instead.

@jvc26 jvc26 changed the title Broken in 1.10 Broken in 1.10 due to option_list (Deprecated Django 1.8) Aug 2, 2016
@jvc26
Copy link
Author

jvc26 commented Aug 2, 2016

This was fixed and merged at e86ccfd, but doesn't appear to have been released on PyPI

@scop
Copy link
Contributor

scop commented Aug 4, 2016

Any ETA for a new release with this fix included?

@diox
Copy link
Member

diox commented Aug 4, 2016

I'll look into that this week.

@diox
Copy link
Member

diox commented Aug 9, 2016

https://pypi.python.org/pypi/django_compressor/2.1 has been released.

@diox diox closed this as completed Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants