Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.4: compressor.exceptions.OfflineGenerationError raised in tests #1237

Open
dvzrv opened this issue Apr 6, 2024 · 4 comments
Open

4.4: compressor.exceptions.OfflineGenerationError raised in tests #1237

dvzrv opened this issue Apr 6, 2024 · 4 comments

Comments

@dvzrv
Copy link

dvzrv commented Apr 6, 2024

Hi! 馃憢

I package this project for Arch Linux.

Due to rebuilds against Python 3.12 I have also rebuilt the project against Python 3.11 and noticed tests failing: test_offline_jinja2_verbosity_2, test_offline_jinja2_verbosity_1, test_offline_jinja2, test_offline_django_verbosity_1, test_offline_django_verbosity_2, test_offline_django

Errors look similar to (below full build/check log):

compressor.exceptions.OfflineGenerationError: You have offline compression enabled but key "9891558d943655c8f923cf5814879f13b26d5cedd15632da46d3f6cd2794d822" is missing from offline manifest. You may need to run "python manage.py compress". Here is the original content:


    <script>alert('amazing');</script>
    <script type="text/javascript" src="/static/js/one.js"></script>

python-django-compressor-4.4-1-x86_64-build.log
python-django-compressor-4.4-1-x86_64-check.log

Disabling singular tests is rather cumbersome with django, so I guess I have to disable them by renaming the test names with sed 馃ゲ

@dvzrv
Copy link
Author

dvzrv commented Apr 6, 2024

I just noticed that #1196 fixes this issue.

The PR has been merged in July of last year. Why is no new version out with this fix?

@carltongibson
Copy link
Contributor

carltongibson commented Apr 6, 2024

There have been no non-bookkeeping changes in the intervening period that would require a release, I'd say.

There are a few issues on the backlog that will need resolving before a Django 5.1 compatibility release, so I have that kind of timeline on my radar for more significant changes.

@diox
Copy link
Member

diox commented Apr 6, 2024

As Carlton said there has been no reason to release a new version yet, nobody has asked for that fix, but I can make a 4.5 now if that's helpful.

@dvzrv
Copy link
Author

dvzrv commented Apr 6, 2024

I can make a 4.5 now if that's helpful.

Thanks, that would generally always be appreciated, as some downstreams do run tests :)
I have applied the patches already, so for me it is fine for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants