Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies are pinned #1195

Open
dvzrv opened this issue Jun 29, 2023 · 1 comment
Open

Dependencies are pinned #1195

dvzrv opened this issue Jun 29, 2023 · 1 comment

Comments

@dvzrv
Copy link

dvzrv commented Jun 29, 2023

Hi! I package this project for Arch Linux.

For system packaging it is problematic to pin dependencies the way it is done in this project:

django-compressor/setup.py

Lines 167 to 168 in 939499e

"rcssmin == 1.1.1",
"rjsmin == 1.2.1",

Downstream we have to remove the specific version pinning, as we are a floating target where only one version of a given library can exist. However, even for user installs of this library it is problematic, as installing django-compressor requires a specific version of these libraries and a different library may require them to be less strict.

@bcail
Copy link
Contributor

bcail commented Jul 14, 2023

@diox Would it be an option to require rcssmin >= 1.1.1 and rjsmin >= 1.2.1? Or to drop the versions completely from setup.py? If so, I could submit a PR.

EDM115 added a commit to EDM115-org/Tab-Magiques that referenced this issue Nov 13, 2023
cannot update rcssmin and rjsmin due to django-compressor==4.4
more info : django-compressor/django-compressor#1195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants