Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim down package #1174

Open
lociii opened this issue Feb 21, 2023 · 1 comment
Open

Slim down package #1174

lociii opened this issue Feb 21, 2023 · 1 comment

Comments

@lociii
Copy link

lociii commented Feb 21, 2023

The MANIFEST includes lots of files in the distribution package that are not necessary to run django-compresssor. All of these statements are more than 10 years old - it may be time to reconsider these choices.

More specifically, I would question why the following are shipped with the package:

  • include Makefile
    • only required to run tests and build coverage report
  • include tox.ini
    • only required to run tests
  • recursive-include docs *
  • recursive-include requirements *
    • required packages to run tests
  • recursive-include compressor/templates/compressor *.html
    • example templates on how to integrate compressed files
  • recursive-include compressor/tests/media *.js *.css *.png *.coffee
    • doesn't even exist anymore
  • recursive-include compressor/tests/test_templates *.html
    • templates used in tests

It's not much but could help slim down installs, docker images, etc.

@carltongibson
Copy link
Contributor

Outdated includes can be removed but downstream packaging folks (for Linux distributions and such) like to have the tests and other such things included so they can test the package themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants