Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server.stop() fails to wait for 'bye' to complete before killing sockets. #97

Open
troppoli opened this issue Oct 30, 2018 · 0 comments

Comments

@troppoli
Copy link

The server.stop call does three things without any synchronization:
sends out a bye
stops the advertise loop
closes sockets

The trouble is that _stop (closing sockets) is called without waiting for _send's callback to complete. So you will see the 'Sending a message to %s:%s' from _send, but you will don't see the 'Outgoing server message' from the completion in advertise. If I put a breakpoint before _stop, this message usually makes it out when I run.

I'm on win 10 with multiple NICs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant