Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CSS class="inline" for inline image elements #4432

Open
stefan-jung opened this issue Mar 12, 2024 · 2 comments
Open

Set CSS class="inline" for inline image elements #4432

stefan-jung opened this issue Mar 12, 2024 · 2 comments

Comments

@stefan-jung
Copy link
Contributor

stefan-jung commented Mar 12, 2024

Description

It would be nice, if an additional CSS class would be added for inline <img> elements. Currently, this does not happen, as you can see in the <xsl:template match="*[contains(@class, ' topic/image ')]" name="topic.image"> template and the <xsl:template name="topic-image"> template. This would simplify the styling of inline images, e.g. to change formatting, positioning, and scaling.

This would be a non-breaking change, quite easy to implement. If you would accept the change, I could send a pull request.

Alternative solutions

Right now, we are setting @outputclass="inline", but this is additional effort, because the information, that this image is an inline image, is already defined by the @placement="inline" attribute.

Possible Solution

Set an additional class, for instance inline.

Test files

html5-inline-image.zip

@chrispy-snps
Copy link
Contributor

This is a great idea! I encourage you to make the pull request; I will support it.

@stefan-jung
Copy link
Contributor Author

@chrispy-snps, because you have said that you want to support it: Maybe you can take the reviewer role and review #4434.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants