Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation subcommand and plug-in #4400

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Add validation subcommand and plug-in #4400

wants to merge 5 commits into from

Conversation

jelovirt
Copy link
Member

Description

Add validation plug-in and validate subcommand to CLI.

Motivation and Context

Fixes #4397

Type of Changes

  • New feature (non-breaking change which adds functionality)

Documentation and Compatibility

TBD

@jelovirt jelovirt added feature New feature or request CLI Command-line interface issues labels Feb 11, 2024
@jelovirt jelovirt linked an issue Feb 11, 2024 that may be closed by this pull request
Add validate subcommand #4397
Open
1 task
@jelovirt jelovirt force-pushed the feature/4397-add-validate-subcommand branch 2 times, most recently from ef935c2 to e144be6 Compare February 11, 2024 14:59
@jelovirt
Add validation plugin
73b8205 
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@jelovirt
Add validate subcommand
1f1c202 
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@jelovirt
Add argument parsing tests for validate subcommand
72f69b7 
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@jelovirt
Support more arguments on validate argument parser
0b08ea5 
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@jelovirt
Skip build steps that are needed for validation
20e8e34 
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@jelovirt jelovirt force-pushed the feature/4397-add-validate-subcommand branch from e144be6 to 20e8e34 Compare March 9, 2024 09:27
@chrispy-snps
Copy link
Contributor

I wanted to try validate out, but I get the following when I try:

$ ./build/tmp/dist/bin/dita validate -i map.ditamap
Error: Build failed with an exception: /.../build/tmp/dist/plugins/org.dita.base/build.xml:35: import requires file attribute or at least one nested resource
        at org.apache.tools.ant.taskdefs.ImportTask.execute(ImportTask.java:134)
        at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:299)
        ...

Have you seen this on your side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLI Command-line interface issues feature New feature or request
Projects
Next
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add validate subcommand
2 participants
@jelovirt @chrispy-snps