Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trajectory output Atom Types #1890

Closed
shrmiao opened this issue May 7, 2024 · 2 comments · Fixed by #1899
Closed

Trajectory output Atom Types #1890

shrmiao opened this issue May 7, 2024 · 2 comments · Fixed by #1899
Assignees
Labels
Type: Enhancement Enhancement for existing feature

Comments

@shrmiao
Copy link

shrmiao commented May 7, 2024

Describe the feature / issue
Accumulated trajectory files can be very useful for post-dissolve analysis and it is a good way to make sure various analysis are performed over the same geometry/energy landscape. Currently, the output trajectory file only contains 4 columns: Element, X-coord, Y-coord, Z-coord.

I think it would be more useful to output: Atom Type, X-coord, Y-coord, Z-coord; so that sites can be differentiated among functional groups (i.e. hydroxyl hydrogen and alkyl hydrogen).

If possible, I think it would be even better if the output could include 6 columns: Element, Atom Type, Atom Index (within the species), X, Y, Z

As an example (2 water molecules per frame):

6 (total number of atoms in 1 frame)
blah blah (box name)
H Hw 1 X Y Z
H Hw 2 X Y Z
O Ow 3 X Y Z
H Hw 1 X Y Z
H Hw 2 X Y Z
O Ow 3 X Y Z
6
blah blah
...

@shrmiao shrmiao added the Type: Enhancement Enhancement for existing feature label May 7, 2024
@rprospero rprospero self-assigned this May 15, 2024
@rprospero
Copy link
Contributor

@shrmiao @trisyoungs Would it be acceptible to have the columns be

  1. Element
  2. X
  3. Y
  4. Z
  5. Atom Type
  6. Atom Index

I mostly ask because this would keep the first four columns in their original order in the case where users already have scripts for analysing these files?

@shrmiao
Copy link
Author

shrmiao commented May 15, 2024

I actually wrote codes based on the first 4 columns too so keeping them the same would be a good idea :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Enhancement for existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants