Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove depreciated temperature label #1843

Open
rhinoella opened this issue Apr 10, 2024 · 1 comment
Open

Remove depreciated temperature label #1843

rhinoella opened this issue Apr 10, 2024 · 1 comment
Labels
2 DIfficulty: 2 Scope: GUI Related to the GUI
Projects

Comments

@rhinoella
Copy link
Contributor

rhinoella commented Apr 10, 2024

Configuration tab still contains depreciated temperature indicator

Screenshots
image

Operating System:

  • OS: OSX
  • OS version / flavour: Ventura
@rhinoella rhinoella added the Type: Bug General bug / issue label Apr 10, 2024
@trisyoungs
Copy link
Member

@rhinoella You are absolutely correct here, but this is more "unexpected behaviour" than it is a bug. The TemperatureProcedureNode is deprecated, and only sets the temperature of the configuration when generating the configuration. Hence, simply changing the value in the node won't change the value in the top-left of the ConfigurationTab (as you have observed) until you "Generate" the configuration again.

There is no easy way to account for this discrepancy until TemperatureProcedureNode is fully removed, so to mitigate the effects we should remove references to it from the documentation, stop them being added programatically in the code when adding configurations, and refer the user to the main menu item instead.

@rhinoella rhinoella removed the Type: Bug General bug / issue label Apr 11, 2024
@rhinoella rhinoella changed the title Temperature is not updated in the configuration overview Remove depreciated temperature label Apr 15, 2024
@rhinoella rhinoella added Scope: GUI Related to the GUI 2 DIfficulty: 2 labels Apr 15, 2024
@github-actions github-actions bot added this to GUI in Overview Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 DIfficulty: 2 Scope: GUI Related to the GUI
Projects
Development

No branches or pull requests

2 participants