Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

def-message-dispatch fails to ex-info exceptional responses #97

Open
kiranshila opened this issue Jan 8, 2022 · 0 comments
Open

def-message-dispatch fails to ex-info exceptional responses #97

kiranshila opened this issue Jan 8, 2022 · 0 comments
Labels
bug report Reported, but unconfirmed bugs.

Comments

@kiranshila
Copy link

Describe the bug
Exceptional responses from the messaging namespace are not wrapped in ex-info, preventing exception handling on Discord errors.

Version Information

  • Clojure Version: 1.11.0-alpha3
  • Discljord Version: 1.3.0
  • OS bot is hosted on: Arch, btw

To Reproduce
Do something incorrectly, like discljord.messaging/edit-original-interaction-response! with a bad payload, the error body comes back from Discord, but as a map.

Expected behavior
Exceptional responses to be wrapped in an ex-info

Additional Context
@IGJoshua mentioned the problem is in

https://github.com/discljord/discljord/blob/master/src/discljord/messaging/impl.clj#L104-L114

Where def-message-dispatch is failing to ex-info, not any particular endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Reported, but unconfirmed bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant