Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How about including fish completion #753

Open
zimbatm opened this issue Jan 27, 2021 · 4 comments · May be fixed by #775
Open

How about including fish completion #753

zimbatm opened this issue Jan 27, 2021 · 4 comments · May be fixed by #775

Comments

@zimbatm
Copy link
Member

zimbatm commented Jan 27, 2021

How about including fish? I started a project since I haven't found another like it. direnv already supports a hook for fish.

Originally posted by @etcusrvar in #443 (comment)
@zimbatm
Copy link
Member Author

zimbatm commented Jan 27, 2021 •
edited

Sounds good! I would be happy to accept a PR for fish completion.

I think it's just a matter of copying the completions folder and updating the GNUMakefile install target.

@zimbatm zimbatm changed the title How about including [fish](https://fishshell.com)? I started a [project](https://github.com/etcusrvar/fish-direnv-completions) since I haven't found another like it. direnv already supports a hook for fish. How about including fish completion Jan 27, 2021
@etcusrvar
Copy link
Contributor

Thanks @zimbatm. Let me work on making the completions I started a bit more robust, then we can work on merging into direnv.

@mrmeszaros
Copy link
Contributor

@etcusrvar I would be glad to help out if I can!
I see that the linked project etcusrvar/fish-direnv-completions is superseded by your fish-completions.

Also, I noticed that the wording of the help for commands is a bit messy - like allow, deny, hook and help.
I suggest to use a unified style - like the one git uses.
For example some rework could be:

allow [PATH]
    Grant authorization to load the given .envrc
deny [PATH]
    Revoke authorization to load the given .envrc
hook [SHELL]
    Setup the shell hook
help [--show-private]
    Show this help

@etcusrvar
Copy link
Contributor

@mrmeszaros yeah I've moved various one-off projects around quite a bit. I've gotten into other tasks recently and haven't looked at fish completions in a while. Feel free to take what I started and improve it and turn it into a PR if you have the bandwidth.

mrmeszaros added a commit to mrmeszaros/direnv that referenced this issue Mar 8, 2021
@mrmeszaros
Start autocomplete generation for fish
846b9f0 
Added complete command that generates basic auto-completions for fish.

Other shells are not yet supported, but the interface can be extended.

Fixes direnv#753
mrmeszaros added a commit to mrmeszaros/direnv that referenced this issue Mar 8, 2021
@mrmeszaros
Start autocomplete generation for fish
4388e5e 
Added `complete` command that generates basic auto-completions for fish.
Other shells are not supported yet.

Fixes direnv#753
@mrmeszaros mrmeszaros linked a pull request Mar 8, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Start autocomplete generation for fish mrmeszaros/direnv
3 participants
@zimbatm @etcusrvar @mrmeszaros