Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect extensions submodule loading selection between DEV and PROD #22329

Closed
shasha79 opened this issue Apr 27, 2024 · 1 comment
Closed

Comments

@shasha79
Copy link

Describe the Bug

https://github.com/directus/directus/blob/main/app/src/extensions.ts#L32

The bug is the reverse check for DEV - if it is true, the "directus-extensions" should be loaded from source, otherwise from submodule, e.g. the correct line should be:

customExtensions = import.meta.env.DEV
? await import(/* @vite-ignore / ${getRootPath()}extensions/sources/index.js);
: await import(/
@vite-ignore */ '@directus-extensions')

To Reproduce

any run

Directus Version

v10.10.7

Hosting Strategy

Self-Hosted (Custom)

@paescuj
Copy link
Member

paescuj commented Apr 27, 2024

No, the check is correct. It is used for dev mode (when running pnpm dev inside /app), where the extensions have to be loaded via virtual @directus-extensions module.
It seems that you have a different problem. If this is the case, please open a new issue with a detailed description. Thanks!

@paescuj paescuj closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants