Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency from nuxt-simple-sitemap to @nuxtjs/sitemap #87

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Abdallah-Awwad
Copy link
Contributor

The nuxt-simple-sitemap package has been deprecated and migrated to @nuxtjs/sitemap.
See: https://www.npmjs.com/package/nuxt-simple-sitemap

Fixes: #86

The nuxt-simple-sitemap package has been deprecated and migrated to @nuxtjs/sitemap.
See https://www.npmjs.com/package/nuxt-simple-sitemap
Copy link

netlify bot commented Apr 28, 2024

👷 Deploy request for agency-os pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0aa94a7

Copy link

vercel bot commented Apr 28, 2024

@Abdallah-Awwad is attempting to deploy a commit to the Directus Team on Vercel.

A member of the Team first needs to authorize it.

@bryantgillespie bryantgillespie self-assigned this May 1, 2024
@sergiocbueno
Copy link

Thanks! This dependency fix works like a charm for me.

@Abdallah-Awwad
Copy link
Contributor Author

@sergiocbueno, Glad it helped! 🤩

Copy link
Contributor

@omgitsjan omgitsjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Use `SITE_URL` instead of `NUXT_PUBLIC_SITE_URL`, as it doesn't exist and was therefore falling back to localhost:3000 in production. `NUXT_PUBLIC_SITE_URL`  isn't noted in the README for the frontend install instructions of AgencyOS and is specific to Nuxt SEO OG:IMAGE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This module cannot be imported in server runtime || og-image not showing
4 participants